filter: fix errors found by fuzz #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manunio
force-pushed
the
fuzz-fix-oom-errors
branch
from
e622cf4 to
2180649
Compare
While fuzzing built-in filters `center` and `indent`, they errored out or caused an OOM due to a large value as input.
manunio
force-pushed
the
fuzz-fix-oom-errors
branch
from
2180649 to
b068ec5
Compare
djc
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fuzzing built-in filters
centerandindent, they errored out or caused an OOM due to a large value as input.For center:
For indent:
cargo +nightly fuzz run fuzz_filters artifacts/fuzz_filters/oom-72ee499821247cdd28e7e114c397347901d4d5c7 Compiling askama v0.13.0 (/home/maxx/dev/security/oss-fuzz-projects/askama-manunio/askama) Compiling askama-fuzz v0.0.0 (/home/maxx/dev/security/oss-fuzz-projects/askama-manunio/fuzz) Finished `release` profile [optimized + debuginfo] target(s) in 3.25s Finished `release` profile [optimized + debuginfo] target(s) in 0.05s Running `target/x86_64-unknown-linux-gnu/release/fuzz_filters -artifact_prefix=/home/maxx/dev/security/oss-fuzz-projects/askama-manunio/fuzz/artifacts/fuzz_filters/ artifacts/fuzz_filters/oom-72ee499821247cdd28e7e114c397347901d4d5c7` INFO: Running with entropic power schedule (0xFF, 100). INFO: Seed: 3494758370 INFO: Loaded 1 modules (12661 inline 8-bit counters): 12661 [0x560504272ec0, 0x560504276035), INFO: Loaded 1 PC tables (12661 PCs): 12661 [0x560504276038,0x5605042a7788), target/x86_64-unknown-linux-gnu/release/fuzz_filters: Running 1 inputs 1 time(s) each. Running: artifacts/fuzz_filters/oom-72ee499821247cdd28e7e114c397347901d4d5c7 8 ==399595== ERROR: libFuzzer: out-of-memory (malloc(2147483648)) To change the out-of-memory limit use -rss_limit_mb=<N>